Closed
Conversation
Especially fix setup-app-layer script to not forget this part
and used by bittorrent
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8884 +/- ##
==========================================
- Coverage 82.30% 82.24% -0.07%
==========================================
Files 969 957 -12
Lines 273240 272798 -442
==========================================
- Hits 224902 224366 -536
- Misses 48338 48432 +94
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information:
Pipeline 13787 |
|
WARNING:
Pipeline 13789 |
|
WARNING:
Pipeline 13790 |
catenacyber
force-pushed
the
output-alert-applayer-v3
branch
from
49957a3 to
9fa961e
Compare
Contributor
Author
|
Does it make sense for bug-4903 to test for ssh tx id ? I think not... |
|
Information: QA ran without warnings. Pipeline 13791 |
|
Information: QA ran without warnings. Pipeline 13794 |
catenacyber
force-pushed
the
output-alert-applayer-v3
branch
from
8d339f2 to
958d65c
Compare
|
Information: QA ran without warnings. Pipeline 13797 |
catenacyber
force-pushed
the
output-alert-applayer-v3
branch
from
958d65c to
81733d6
Compare
And fix setup app layer script up for it
catenacyber
force-pushed
the
output-alert-applayer-v3
branch
from
81733d6 to
8252ae7
Compare
|
Information: QA ran without warnings. Pipeline 13807 |
This was referenced May 17, 2023
Contributor
Author
|
Replaced by #8893 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None, preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins
Continuation of #8772
Describe changes:
Continues #8872 by having JsonGenericLogger to remove more boilerplate C code
OISF/suricata-verify#1196
Still to do :